Skip to content

fix: run PR Sync before metadata validation - #33

Merged
v-Kaefer merged 5 commits into
developfrom
fix/pr-sync-before-metadata
Aug 10, 2026
Merged

fix: run PR Sync before metadata validation#33
v-Kaefer merged 5 commits into
developfrom
fix/pr-sync-before-metadata

Conversation

@v-Kaefer

@v-Kaefer v-Kaefer commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Linked Issue

Milestone

  • PR automation / workflow ordering hardening

Summary

  • Make PR Sync the first PR automation gate by running it directly on opened, synchronize, reopened, edited, ready-for-review, converted-to-draft and closed events.
  • Make PR metadata validation run only after a successful PR Sync workflow completion.
  • Resolve the current PR body/head/base from GitHub in the metadata validator because its trigger is now workflow_run instead of pull_request_target.
  • Preserve the previous draft/closed behavior by skipping active metadata validation for draft or closed PRs.
  • Treat develop -> Q.A and Q.A -> main as full promotion exceptions for implementation metadata body validation, preventing promotion PRs such as Develop #31 from failing on the generic placeholder template.

How to test

  • Test type: automated / live follow-up
  • Steps: run repository quality/unit tests and verify the workflow-contract tests require PR Sync direct lifecycle triggers plus metadata dependency on successful PR Sync.
  • After promotion to main, trigger a fresh PR event and verify the order is PR Sync first, then PR metadata validation only after Sync succeeds.
  • Verify promotion PR Develop #31 no longer fails implementation metadata validation because of template placeholders.

Evidence

  • Diff limited to PR Sync workflow, metadata workflow, metadata resolver/validator and regression tests.
  • PR Sync no longer contains a workflow_run dependency on metadata/guardrails.
  • Metadata workflow now listens to completed PR Sync runs and requires successful conclusion.
  • Promotion metadata exception is covered by regression tests.
  • Repository quality run 31417327025 passed on head f2c70d6411001b2bb2f338abbfb35677533b8311.
  • make check passed with 70 tests, including the new workflow ordering and promotion metadata regression tests.
  • Fresh post-main live event confirms runtime ordering.

Known risks

  • workflow_run chaining is effective only after this workflow definition reaches the default branch; feature-branch CI validates the contract but cannot replace the final post-main live test.
  • Metadata validation intentionally does not run if PR Sync fails, because it is now downstream of PR Sync by design.

DoD checklist

  • PR Sync runs independently of metadata validation.
  • Metadata validation depends on successful PR Sync.
  • Draft/closed behavior preserved.
  • Promotion PR metadata placeholder failure removed.
  • Regression coverage updated.
  • Hosted repository checks green.
  • Live post-main validation complete.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@v-Kaefer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e785bab3-a127-45cd-bfc3-603252310c36

📥 Commits

Reviewing files that changed from the base of the PR and between e193151 and f2c70d6.

📒 Files selected for processing (5)
  • .github/workflows/pr-metadata.yml
  • .github/workflows/pr-sync.yml
  • project_setup/pr_validation.py
  • scripts/validation/validate_pr_body.py
  • tests/test_pr_sync.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Sync

@v-Kaefer
v-Kaefer merged commit 655876e into develop Aug 10, 2026
6 checks passed
@v-Kaefer
v-Kaefer deleted the fix/pr-sync-before-metadata branch August 10, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@v-Kaefer v-Kaefer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@v-Kaefer